Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14445 )
Change subject: [tablet] Optimize TabletMetadata::CollectBlockIds efficiency ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/14445/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14445/6//COMMIT_MSG@23 PS6, Line 23: the other columns show 10 times total TabletMetadata::CollectBlockIds() > For future readers, perhaps you could also include the list and deque resul Done http://gerrit.cloudera.org:8080/#/c/14445/6/src/kudu/fs/block_id.h File src/kudu/fs/block_id.h: http://gerrit.cloudera.org:8080/#/c/14445/6/src/kudu/fs/block_id.h@23 PS6, Line 23: #include <iosfwd> > Probably don't need this anymore. Done -- To view, visit http://gerrit.cloudera.org:8080/14445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ce853e35eb7dfa9f9a099e465ea8edfaa7c4aa9 Gerrit-Change-Number: 14445 Gerrit-PatchSet: 7 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 15 Nov 2019 06:12:32 +0000 Gerrit-HasComments: Yes
