Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14736 )
Change subject: [Java] Fixed Type.getTypeForName method. ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/14736/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14736/3//COMMIT_MSG@10 PS3, Line 10: Output from name() (inerrithed from Enum) method was different from output from Type.getName() method (ie INT32 vs int32), so the check fails. Nit: this line is too long; please wrap it. http://gerrit.cloudera.org:8080/#/c/14736/3/java/kudu-client/src/main/java/org/apache/kudu/Type.java File java/kudu-client/src/main/java/org/apache/kudu/Type.java: http://gerrit.cloudera.org:8080/#/c/14736/3/java/kudu-client/src/main/java/org/apache/kudu/Type.java@199 PS3, Line 199: * @param name The DataType name. It accepts Type name (from getName() method) and ENUM name (from name() method). Nit: also too long, please wrap. http://gerrit.cloudera.org:8080/#/c/14736/3/java/kudu-client/src/test/java/org/apache/kudu/TestType.java File java/kudu-client/src/test/java/org/apache/kudu/TestType.java: http://gerrit.cloudera.org:8080/#/c/14736/3/java/kudu-client/src/test/java/org/apache/kudu/TestType.java@32 PS3, Line 32: @Rule : public ExpectedException expectedException = ExpectedException.none(); : Doesn't seem like you're using this in the test? http://gerrit.cloudera.org:8080/#/c/14736/3/java/kudu-client/src/test/java/org/apache/kudu/TestType.java@41 PS3, Line 41: Nit: leading whitespace here, please remove. -- To view, visit http://gerrit.cloudera.org:8080/14736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd0f4f614125d630d128c36fce05f22e19c60100 Gerrit-Change-Number: 14736 Gerrit-PatchSet: 3 Gerrit-Owner: Michele Milesi <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michele Milesi <[email protected]> Gerrit-Comment-Date: Tue, 19 Nov 2019 05:30:49 +0000 Gerrit-HasComments: Yes
