Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14736 )
Change subject: [Java] Fixed Type.getTypeForName method. ...................................................................... Patch Set 5: (4 comments) Looks good to me, just a few nits. http://gerrit.cloudera.org:8080/#/c/14736/5/java/kudu-client/src/main/java/org/apache/kudu/Type.java File java/kudu-client/src/main/java/org/apache/kudu/Type.java: http://gerrit.cloudera.org:8080/#/c/14736/5/java/kudu-client/src/main/java/org/apache/kudu/Type.java@199 PS5, Line 199: the http://gerrit.cloudera.org:8080/#/c/14736/5/java/kudu-client/src/main/java/org/apache/kudu/Type.java@199 PS5, Line 199: Nit: Trailing whitespace http://gerrit.cloudera.org:8080/#/c/14736/5/java/kudu-client/src/main/java/org/apache/kudu/Type.java@200 PS5, Line 200: the http://gerrit.cloudera.org:8080/#/c/14736/5/java/kudu-client/src/main/java/org/apache/kudu/Type.java@201 PS5, Line 201: * @return a matching Type. Can you add an @throws for the IllegalArgumentException? -- To view, visit http://gerrit.cloudera.org:8080/14736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd0f4f614125d630d128c36fce05f22e19c60100 Gerrit-Change-Number: 14736 Gerrit-PatchSet: 5 Gerrit-Owner: Michele Milesi <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michele Milesi <[email protected]> Gerrit-Comment-Date: Wed, 20 Nov 2019 13:55:24 +0000 Gerrit-HasComments: Yes
