Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14747 )
Change subject: [java] Fix medium SpotBugs issues ...................................................................... Patch Set 3: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml File java/config/spotbugs/excludeFilter.xml: PS1: > That might be possible. Could it be follow on work? Yeah for sure. http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@28 PS1, Line 28: <Class name="~org\.apache\.kudu\.consensus\.Opid.*"/> > The actual issue is reported on `Opid$OpId$Builder` Ah, forgot about the implicit builder nested classes. http://gerrit.cloudera.org:8080/#/c/14747/1/java/config/spotbugs/excludeFilter.xml@30 PS1, Line 30: <Class name="~org\.apache\.kudu\.rpc\.RpcHeader.*"/> > I was okay being heavy handed given the ideal outcome is ignoring all Proto Could you use the <Source/> element to match everything with /proto/ in its path? That would match all the generated code: ./build/generated/source/proto/main/java/org/apache/kudu/consensus/Metadata.java ./build/generated/source/proto/main/java/org/apache/kudu/consensus/Opid.java ./build/generated/source/proto/main/java/org/apache/kudu/consensus/Consensus.java ./build/generated/source/proto/main/java/org/apache/kudu/master/Master.java ... -- To view, visit http://gerrit.cloudera.org:8080/14747 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f Gerrit-Change-Number: 14747 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 20 Nov 2019 05:39:31 +0000 Gerrit-HasComments: Yes
