Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14747 )
Change subject: [java] Fix medium SpotBugs issues ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14747/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14747/2//COMMIT_MSG@7 PS2, Line 7: SpotBugs > This is a bug from the previous/parent patch, I will fix it there. Thank you for fixing that. Now it works for me (i.e. './gradlew check' doesn't output such an error). http://gerrit.cloudera.org:8080/#/c/14747/2//COMMIT_MSG@13 PS2, Line 13: enforce SpotBugs Once the issue with invoking SpotBugs in PS2 has been addressed, I tried to run it against the code again, and it reported 'all is well': aserbin-mbp:java[java-lint]$ ./gradlew spotBugs Starting a Gradle Daemon (subsequent builds will be faster) BUILD SUCCESSFUL in 1m 33s 89 actionable tasks: 22 executed, 67 up-to-date However, java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java contained the bug that was fixed in 91d196f33 (i.e. the connection negotiation bug addressed recently). Does it mean SpotBugs is not able to detect such issues, and we should resort to something else (i.e. add some other lint tool) to detect those? I know that the code inspection of IntelliJ is able to detect the bug, at least in 2018.3.4 Community Edition. -- To view, visit http://gerrit.cloudera.org:8080/14747 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f66176dcca9dbf77853b54bef20d947f3732e3f Gerrit-Change-Number: 14747 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 20 Nov 2019 06:22:06 +0000 Gerrit-HasComments: Yes
