Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14783 )

Change subject: KUDU-3008 Spread replicas evenly with 2 locations and odd 
replica factors
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14783/1/src/kudu/master/placement_policy-test.cc
File src/kudu/master/placement_policy-test.cc:

http://gerrit.cloudera.org:8080/#/c/14783/1/src/kudu/master/placement_policy-test.cc@858
PS1, Line 858:     // Before this patch, all replicas will located at "B".
> nit: this comment doesn't have enough context if reading it as part of the
Also, I think it's better to make this test-wide comment (i.e. put it at line 
847)



--
To view, visit http://gerrit.cloudera.org:8080/14783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96361f6be686679dd72f08e28d964eae25875d0
Gerrit-Change-Number: 14783
Gerrit-PatchSet: 1
Gerrit-Owner: ZhangYao <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 22 Nov 2019 20:09:36 +0000
Gerrit-HasComments: Yes

Reply via email to