ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14783 )
Change subject: KUDU-3008 Spread replicas evenly with 2 locations and odd replica factors ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/14783/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14783/1//COMMIT_MSG@8 PS1, Line 8: > Could you add some description here? The idea is to outline why 2 + 1 is b Of course:) Done http://gerrit.cloudera.org:8080/#/c/14783/1/src/kudu/master/placement_policy-test.cc File src/kudu/master/placement_policy-test.cc: http://gerrit.cloudera.org:8080/#/c/14783/1/src/kudu/master/placement_policy-test.cc@858 PS1, Line 858: > Also, I think it's better to make this test-wide comment (i.e. put it at li Done http://gerrit.cloudera.org:8080/#/c/14783/1/src/kudu/master/placement_policy-test.cc@858 PS1, Line 858: > nit: this comment doesn't have enough context if reading it as part of the Done http://gerrit.cloudera.org:8080/#/c/14783/1/src/kudu/master/placement_policy.cc File src/kudu/master/placement_policy.cc: http://gerrit.cloudera.org:8080/#/c/14783/1/src/kudu/master/placement_policy.cc@337 PS1, Line 337: // is (3 + 3), while for 3 locations that's (2 + 2 + 2). In case of > Could you add a small note about distributing 3 replicas into 2 locations? Done -- To view, visit http://gerrit.cloudera.org:8080/14783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If96361f6be686679dd72f08e28d964eae25875d0 Gerrit-Change-Number: 14783 Gerrit-PatchSet: 2 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Sat, 23 Nov 2019 12:20:32 +0000 Gerrit-HasComments: Yes
