Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14793 )
Change subject: [test] Avoid mod 0, 'kMaxLimit' may be 0, then an exception reported like 'Floating point exception'. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14793/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14793/1//COMMIT_MSG@7 PS1, Line 7: [test] Avoid mod 0, 'kMaxLimit' may be 0, then an exception reported like 'Floating point exception'. Nit: This subject is too long. Can you set a brief subject and then use the description for a longer explanation? http://gerrit.cloudera.org:8080/#/c/14793/1/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/14793/1/src/kudu/tserver/tablet_server-test.cc@2496 PS1, Line 2496: if (kMaxLimit == 0) { This would skip all when the kNumRows = 0. Instead should we make sure the lowest value generated for kNumRows is 100? -- To view, visit http://gerrit.cloudera.org:8080/14793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia45372ff5e5460d220b7a3040de2e499541bf37f Gerrit-Change-Number: 14793 Gerrit-PatchSet: 1 Gerrit-Owner: YangSong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 25 Nov 2019 19:46:40 +0000 Gerrit-HasComments: Yes
