Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14793 )
Change subject: [test] Avoid mod 0, 'kMaxLimit' may be 0, then an exception reported like 'Floating point exception'. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14793/1/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/14793/1/src/kudu/tserver/tablet_server-test.cc@2500 PS1, Line 2500: const int kLimit = rand() % kMaxLimit + 1 As an alternative to continuing with next iteration, I think it's possible to replace this with: const int kLimit = kMaxLimit == 0 ? 1 : rand() % kMaxLimit + 1; -- To view, visit http://gerrit.cloudera.org:8080/14793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia45372ff5e5460d220b7a3040de2e499541bf37f Gerrit-Change-Number: 14793 Gerrit-PatchSet: 1 Gerrit-Owner: YangSong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 25 Nov 2019 22:48:02 +0000 Gerrit-HasComments: Yes
