Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14796 )
Change subject: [java] Remove PMD static analysis ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14796/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14796/1//COMMIT_MSG@11 PS1, Line 11: Checkstyle, ErrorProne, > Is either of these able to detect issues like we fixed in https://github.co SpotBugs is supposed to but didn't for some reason. I am still looking into that. ErrorProne can detect a completely unused field, but not one that is just unwritten like peerCerts. Regardless, PMD isn't useful for that either and it doesn't really provide any extra beneficial coverage. -- To view, visit http://gerrit.cloudera.org:8080/14796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If454b4195c987a15b9c07aceef04f028ab1496d5 Gerrit-Change-Number: 14796 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 26 Nov 2019 20:56:18 +0000 Gerrit-HasComments: Yes
