Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14796 )
Change subject: [java] Remove PMD static analysis ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14796/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14796/1//COMMIT_MSG@11 PS1, Line 11: Checkstyle, ErrorProne, > SpotBugs is supposed to but didn't for some reason. I am still looking into Thank you for the clarification. Yep, from https://pmd.github.io/ and examples it seems PMD would be an extra when we already got Checkstyle, ErrorProne and SpotBugs. Maybe, it could be useful in CPD (copy-paste detection), but I don't think that's the coverage we want to get for Kudu Java client code. -- To view, visit http://gerrit.cloudera.org:8080/14796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If454b4195c987a15b9c07aceef04f028ab1496d5 Gerrit-Change-Number: 14796 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 26 Nov 2019 23:23:59 +0000 Gerrit-HasComments: Yes
