YangSong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14654 )
Change subject: KUDU-2975: Spread WAL across multiple directories ...................................................................... Patch Set 20: (1 comment) http://gerrit.cloudera.org:8080/#/c/14654/3/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/14654/3/src/kudu/tserver/ts_tablet_manager.cc@1471 PS3, Line 1471: MAYBE_FAULT(FLAGS_fault_crash_after_blocks_deleted); : : // We do not delete the super > Rather than including this here (and doing another Flush()), could we move I'm not sure it's safe. if a tablet has just been created, and we write two records into it, the delete it. that mean there is no data in the disk, all data is in MemRowSet. What will happen when the WAL deletion succeeds but the metadata deletion fails? If the tablet's WAL directory is deleted, we will find the tablet has no data blocks and no WAL, It will be reinitialized as a new tablet. I have no way to distinguish this exception with creating a new tablet. Another case, if just a segment is deleted, I have not read the replaying log code deeply. I'm not sure Kudu can check out this exception. Maybe the index file can tell out this exception. -- To view, visit http://gerrit.cloudera.org:8080/14654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied496804421d91ff1fa63d49979fde971071506e Gerrit-Change-Number: 14654 Gerrit-PatchSet: 20 Gerrit-Owner: YangSong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Wed, 27 Nov 2019 08:55:21 +0000 Gerrit-HasComments: Yes
