YangSong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14654 )
Change subject: KUDU-2975: Spread WAL across multiple directories ...................................................................... Patch Set 20: (1 comment) http://gerrit.cloudera.org:8080/#/c/14654/3/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/14654/3/src/kudu/tserver/ts_tablet_manager.cc@1471 PS3, Line 1471: MAYBE_FAULT(FLAGS_fault_crash_after_blocks_deleted); : : // We do not delete the super > I'm not sure it's safe. if a tablet has just been created, and we write two The other way I think about it is modifying the parameters of the function Log::DeleteOnDiskData and Log::RemoveRecoveryDirIfExists. like this: Status Log::DeleteOnDiskData(const string& wal_dir, const string& tablet_id) Status Log::RemoveRecoveryDirIfExists(const string& wal_dir, const string& tablet_id) it looks safer. -- To view, visit http://gerrit.cloudera.org:8080/14654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied496804421d91ff1fa63d49979fde971071506e Gerrit-Change-Number: 14654 Gerrit-PatchSet: 20 Gerrit-Owner: YangSong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Wed, 27 Nov 2019 09:11:36 +0000 Gerrit-HasComments: Yes
