Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14784 )
Change subject: KUDU-3006: deflake RebalanceIgnoredTserversTest.Basic ...................................................................... Patch Set 1: (5 comments) Looks good overall, a couple of nits and one question. http://gerrit.cloudera.org:8080/#/c/14784/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14784/1//COMMIT_MSG@10 PS1, Line 10: if we run the reblancing If running the rebalancing prior to that http://gerrit.cloudera.org:8080/#/c/14784/1//COMMIT_MSG@10 PS1, Line 10: reblancing rebalancing http://gerrit.cloudera.org:8080/#/c/14784/1//COMMIT_MSG@9 PS1, Line 9: When starting a cluster and create a table, some replicas may be : unhealthy, It takes some time for the newly created replicas to bootstrap and get their status reported as 'healthy' in the catalog manager. http://gerrit.cloudera.org:8080/#/c/14784/1/src/kudu/tools/rebalancer_tool-test.cc File src/kudu/tools/rebalancer_tool-test.cc: http://gerrit.cloudera.org:8080/#/c/14784/1/src/kudu/tools/rebalancer_tool-test.cc@309 PS1, Line 309: an nit: a http://gerrit.cloudera.org:8080/#/c/14784/1/src/kudu/tools/rebalancer_tool-test.cc@372 PS1, Line 372: ASSERT_EVENTUALLY([&]() { : ASSERT_TOOL_OK( : "cluster", : "ksck", : cluster_->master()->bound_rpc_addr().ToString() : ); : }); Is it really necessary? If so, please add a comment explaining the reasoning. -- To view, visit http://gerrit.cloudera.org:8080/14784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4b248a5fc91dac0dd6303da08f3b304878bfa2 Gerrit-Change-Number: 14784 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 27 Nov 2019 19:58:17 +0000 Gerrit-HasComments: Yes
