Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14784 )
Change subject: KUDU-3006: deflake RebalanceIgnoredTserversTest.Basic ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/14784/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14784/1//COMMIT_MSG@9 PS1, Line 9: It takes some time for the newly created replicas to bootstrap : and get th > It takes some time for the newly created replicas to bootstrap and get thei Done http://gerrit.cloudera.org:8080/#/c/14784/1//COMMIT_MSG@10 PS1, Line 10: ir status reported as 'h > If running the rebalancing prior to that Done http://gerrit.cloudera.org:8080/#/c/14784/1//COMMIT_MSG@10 PS1, Line 10: rted as 'h > rebalancing Done http://gerrit.cloudera.org:8080/#/c/14784/1/src/kudu/tools/rebalancer_tool-test.cc File src/kudu/tools/rebalancer_tool-test.cc: http://gerrit.cloudera.org:8080/#/c/14784/1/src/kudu/tools/rebalancer_tool-test.cc@309 PS1, Line 309: a > nit: a Done http://gerrit.cloudera.org:8080/#/c/14784/1/src/kudu/tools/rebalancer_tool-test.cc@372 PS1, Line 372: // Assign two ignored tservers, one of which is unhealthy, : // '-move_replicas_from_ignored_tservers' and : // '-output_replica_distribution_details' are both enabled. : auto* ts = cluster_->tablet_server(1); : ASSERT_NE(nullptr, ts); : ts->Shutdown(); : { > Is it really necessary? If so, please add a comment explaining the reasoni I thought it's not necessary here and removed it. -- To view, visit http://gerrit.cloudera.org:8080/14784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4b248a5fc91dac0dd6303da08f3b304878bfa2 Gerrit-Change-Number: 14784 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 28 Nov 2019 15:30:15 +0000 Gerrit-HasComments: Yes
