Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14801 )
Change subject: [java] Enable and fix low SpotBugs warnings ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14801/3/java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java: http://gerrit.cloudera.org:8080/#/c/14801/3/java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java@116 PS3, Line 116: if (!hasNext()) { : throw new NoSuchElementException(); : } > What would this do previously? Throw a different exception somewhere else? I think various different exceptions could be thrown depending on the state. http://gerrit.cloudera.org:8080/#/c/14801/3/java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java File java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java: http://gerrit.cloudera.org:8080/#/c/14801/3/java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java@437 PS3, Line 437: return new X509Certificate[0]; > This seems like a real functional change. What motivated it? The X509TrustManager interface documentation states that this should return "a non-null (possibly empty) array of acceptable CA issuer certificates." The motivation was a spotbugs report of "PZLA_PREFER_ZERO_LENGTH_ARRAYS: Consider returning a zero length array rather than null". -- To view, visit http://gerrit.cloudera.org:8080/14801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e5c8285554ff84e948c0ea095ba476969377440 Gerrit-Change-Number: 14801 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 27 Nov 2019 20:52:16 +0000 Gerrit-HasComments: Yes
