Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14801 )
Change subject: [java] Enable and fix low SpotBugs warnings ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14801/3/java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java File java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java: http://gerrit.cloudera.org:8080/#/c/14801/3/java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java@437 PS3, Line 437: return new X509Certificate[0]; > https://stackoverflow.com/questions/42294136/in-x509trustmanager-what-are-m Yep, I think it's correct. As for the authoritative docs on that, there is https://docs.oracle.com/javase/8/docs/api/javax/net/ssl/X509TrustManager.html#getAcceptedIssuers-- So, the methods should not return null, but an empty array instead. I think the important point is that the overridden method is not used anywhere, but it was necessary to override it because of the implement-an-interface requirements. -- To view, visit http://gerrit.cloudera.org:8080/14801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e5c8285554ff84e948c0ea095ba476969377440 Gerrit-Change-Number: 14801 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 28 Nov 2019 06:56:30 +0000 Gerrit-HasComments: Yes
