Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14743 )
Change subject: KUDU-3001 Multi-thread to load containers in a data directory ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/14743/5/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/14743/5/src/kudu/fs/log_block_manager.cc@2411 PS5, Line 2411: "Unable to append deletion record to block metadata"); > Ah, yeah I forgot about that restriction. And it'd be difficult to address. I'd prefer the later idea, the former one is more difficult to design, and might make other developers confused to use. I did some benchmarks after the last patch set, it provides similar performance as what I wrote in the commit message. http://gerrit.cloudera.org:8080/#/c/14743/5/src/kudu/fs/log_block_manager.cc@2414 PS5, Line 2414: deleted->emplace_back(lb->block_id()); > This is where consolidating behind the DataDir thread pool makes it easier Done -- To view, visit http://gerrit.cloudera.org:8080/14743 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0721ee4a5a6824db146ba0658e60eec25dd0c65c Gerrit-Change-Number: 14743 Gerrit-PatchSet: 10 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: wangning <[email protected]> Gerrit-Comment-Date: Sat, 30 Nov 2019 10:30:44 +0000 Gerrit-HasComments: Yes
