Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14743 )

Change subject: KUDU-3001 Multi-thread to load containers in a data directory
......................................................................


Patch Set 11:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14743/10/src/kudu/fs/data_dirs.h
File src/kudu/fs/data_dirs.h:

http://gerrit.cloudera.org:8080/#/c/14743/10/src/kudu/fs/data_dirs.h@225
PS10, Line 225:   // Defaults to the value of FLAGS_block_manager.
> This doesn't seem like state that the DataDir should manage, given how tran
Done


http://gerrit.cloudera.org:8080/#/c/14743/10/src/kudu/fs/log_block_manager.cc
File src/kudu/fs/log_block_manager.cc:

http://gerrit.cloudera.org:8080/#/c/14743/10/src/kudu/fs/log_block_manager.cc@2483
PS10, Line 2483:     if (!TryStripSuffixString(
> Don't we want to parallelize this? It's at least two seeks: one for the dat
Done



--
To view, visit http://gerrit.cloudera.org:8080/14743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0721ee4a5a6824db146ba0658e60eec25dd0c65c
Gerrit-Change-Number: 14743
Gerrit-PatchSet: 11
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: wangning <[email protected]>
Gerrit-Comment-Date: Thu, 05 Dec 2019 03:58:29 +0000
Gerrit-HasComments: Yes

Reply via email to