Hello Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14818
to review the following change.
Change subject: log: some cleanup and modernization
......................................................................
log: some cleanup and modernization
- Use pass by move when replacing LogReader segments.
- Remove WritableLogSegment::writable_file() private accessor. Internal code
can just as easily use writable_file_ directly.
- Make some RETURN_NOT_OK_PREPEND messages actually useful.
- Reduce unnecessary usage of more complex LogReader::Open variant.
Change-Id: I3106ede5243d05b2a43f8d43f581316b6ee7ada5
---
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/log_reader.cc
M src/kudu/consensus/log_reader.h
M src/kudu/consensus/log_util.cc
M src/kudu/consensus/log_util.h
M src/kudu/integration-tests/timestamp_advancement-itest.cc
7 files changed, 37 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/14818/1
--
To view, visit http://gerrit.cloudera.org:8080/14818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3106ede5243d05b2a43f8d43f581316b6ee7ada5
Gerrit-Change-Number: 14818
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
