Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14818 )
Change subject: log: some cleanup and modernization ...................................................................... log: some cleanup and modernization - Use pass by move when replacing LogReader segments. - Remove WritableLogSegment::writable_file() private accessor. Internal code can just as easily use writable_file_ directly. - Make some RETURN_NOT_OK_PREPEND messages actually useful. - Reduce unnecessary usage of more complex LogReader::Open variant. Change-Id: I3106ede5243d05b2a43f8d43f581316b6ee7ada5 Reviewed-on: http://gerrit.cloudera.org:8080/14818 Reviewed-by: Andrew Wong <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Adar Dembo <[email protected]> --- M src/kudu/consensus/log.cc M src/kudu/consensus/log.h M src/kudu/consensus/log_reader.cc M src/kudu/consensus/log_reader.h M src/kudu/consensus/log_util.cc M src/kudu/consensus/log_util.h M src/kudu/integration-tests/timestamp_advancement-itest.cc 7 files changed, 37 insertions(+), 40 deletions(-) Approvals: Andrew Wong: Looks good to me, approved Alexey Serbin: Looks good to me, but someone else must approve Adar Dembo: Verified -- To view, visit http://gerrit.cloudera.org:8080/14818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3106ede5243d05b2a43f8d43f581316b6ee7ada5 Gerrit-Change-Number: 14818 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]>
