Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14601 )
Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/14601/9/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14601/9/src/kudu/master/catalog_manager.cc@5599 PS9, Line 5599: Record the tablet What does 'record the tablet' mean? Could you clarify? http://gerrit.cloudera.org:8080/#/c/14601/9/src/kudu/master/catalog_manager.cc@5599 PS9, Line 5599: // Record the tablet while the new_stats doesn't support 'live_row_count'. But the : // new_stats will keep coming, so it's necessary to limit the recording operation : // to fire only once. : // Here we use the 'on_disk_size' metric of the old_stats when it is transitioned : // from "uninitialized stats" to "has_on_disk_size()". I think it makes sense to move this inside the 'else if ()' clause below: that way it will be more readable. http://gerrit.cloudera.org:8080/#/c/14601/9/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/14601/9/src/kudu/util/metrics.h@786 PS9, Line 786: // Return true if this metric is invisible otherwise false. nit: add an empty line between the end of the previous function definition and the start of the comment for IsInvisible() -- To view, visit http://gerrit.cloudera.org:8080/14601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7ac5ca7e8ce9dcc37035a7bc46ca69060d6533 Gerrit-Change-Number: 14601 Gerrit-PatchSet: 9 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Wed, 04 Dec 2019 01:50:21 +0000 Gerrit-HasComments: Yes
