helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14601 )
Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI ...................................................................... Patch Set 6: (3 comments) Thanks :) http://gerrit.cloudera.org:8080/#/c/14601/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14601/6/src/kudu/master/catalog_manager.cc@5591 PS6, Line 5591: will trigger > nit: makes Done http://gerrit.cloudera.org:8080/#/c/14601/6/src/kudu/master/catalog_manager.cc@5599 PS6, Line 5599: !old_stats.has_on_disk_size() > It's not easy to follow the logic of these conditionals without knowing the Done http://gerrit.cloudera.org:8080/#/c/14601/6/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/14601/6/src/kudu/master/master-test.cc@1824 PS6, Line 1824: //old_stats.set_on_disk_size(1); > Remove this commented out line, it's not needed. Done -- To view, visit http://gerrit.cloudera.org:8080/14601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7ac5ca7e8ce9dcc37035a7bc46ca69060d6533 Gerrit-Change-Number: 14601 Gerrit-PatchSet: 6 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Thu, 28 Nov 2019 15:06:25 +0000 Gerrit-HasComments: Yes
