Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14819 )
Change subject: log: remove SegmentAllocator functors ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14819/3/src/kudu/consensus/log_reader.h File src/kudu/consensus/log_reader.h: http://gerrit.cloudera.org:8080/#/c/14819/3/src/kudu/consensus/log_reader.h@58 PS3, Line 58: each of these patterns > this pattern What I'm trying to say is that UpdateLastSegmentOffset is an example of "mutating a segment in a thread-safe manner", and ReplaceLastSegment is an example of "make a copy of the segment, modify what you want to modify, then replace the segment atomically". These are two different access patterns, hence the use of 'patterns' in the plural. Can you help me come up with a clearer way to express this? -- To view, visit http://gerrit.cloudera.org:8080/14819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2f5dd47e3be930288dcfeb1f77409fda45daac4 Gerrit-Change-Number: 14819 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 04 Dec 2019 18:31:47 +0000 Gerrit-HasComments: Yes
