Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14819 )
Change subject: log: remove SegmentAllocator functors ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14819/3/src/kudu/consensus/log_reader.h File src/kudu/consensus/log_reader.h: http://gerrit.cloudera.org:8080/#/c/14819/3/src/kudu/consensus/log_reader.h@58 PS3, Line 58: each of these patterns > add "respectively" No, I misread this. Once initialized, care should be taken to avoid mutating the segments in a non-thread-safe manner. E.g. segment mutation should be made thread-safe with locking primitives, or done via a copy-then-replace access pattern. UpdateLastSegmentOffset and ReplaceLastSegment are examples of each these patterns respectively. -- To view, visit http://gerrit.cloudera.org:8080/14819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2f5dd47e3be930288dcfeb1f77409fda45daac4 Gerrit-Change-Number: 14819 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 04 Dec 2019 19:16:50 +0000 Gerrit-HasComments: Yes
