Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14836 )
Change subject: external_mini_cluster: actually default to system_unsync time source ...................................................................... Patch Set 2: (1 comment) Thank you for putting together this patch. I think we should keep it here to submit a bit later. I added more details into the file-level comment for the Commit Message. http://gerrit.cloudera.org:8080/#/c/14836/2//COMMIT_MSG Commit Message: PS2: It seems I haven't communicated clearly on my plan w.r.t. updates on the time source for our tests in commit message for eb2b70d4b96be2fc2fdd6b3625acc284ac5774be. The idea was to have some extended coverage for the built-in NTP client exercised by the set of tests we have there since we don't have enough coverage for the biult-in NTP client in terms of end-to-end testing. Meanwhile, I thought to separate some of those and also adding more specific ones. After that, we can switch the rest of the external mini-cluster tests to the system_unsync time source. TL;DR: let's keep this patch, and submit it as soon as the necessary end-to-end coverage for the built-in NTP client is there. -- To view, visit http://gerrit.cloudera.org:8080/14836 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eefdea607d5631e11868a49341f51e120a0ba36 Gerrit-Change-Number: 14836 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 04 Dec 2019 23:02:34 +0000 Gerrit-HasComments: Yes
