Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14839 )
Change subject: clang_tidy_gerrit: disable llvm-include-order check ...................................................................... Patch Set 1: > As discussed on Slack, it seems the issue is on IWYU side and it's > sorting incorrectly. We should fix that if possible and merge this > only if it turns out to be too much work. > > If we don't fix IWYU we will need to change includes in existing > files whenever we change anything in them. Yeah, it would be nice to fix it. However, IWYU has been around for a couple of years, and I'm not sure we have seen many instances of this problem. -- To view, visit http://gerrit.cloudera.org:8080/14839 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1f0e3a5b8447940be74071cc6701ac5eb5ddcf6 Gerrit-Change-Number: 14839 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 05 Dec 2019 01:26:38 +0000 Gerrit-HasComments: No
