Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14839 )
Change subject: clang_tidy_gerrit: disable llvm-include-order check ...................................................................... Patch Set 1: Code-Review+2 (1 comment) > Patch Set 1: > > > > As discussed on Slack, it seems the issue is on IWYU side and > > it's > > > sorting incorrectly. We should fix that if possible and merge > > this > > > only if it turns out to be too much work. > > > > > > If we don't fix IWYU we will need to change includes in existing > > > files whenever we change anything in them. > > > > Yeah, it would be nice to fix it. However, IWYU has been around > > for a couple of years, and I'm not sure we have seen many instances > > of this problem. > > It seems IWYU does the re-ordering intentionally: > > https://github.com/apache/kudu/blob/89ce529e945731c48445db4a6f8af11f9f905aab/build-support/iwyu/fix_includes.py#L1784-L1787 > > I think the reasoning is that in some cases including 'x-inl.h' before 'x.h' > might lead to compilation errors due to the some conventions. Yep, let's disable clang-tidy then. I left a comment about a comment, but otherwise looks good. http://gerrit.cloudera.org:8080/#/c/14839/1/build-support/clang_tidy_gerrit.py File build-support/clang_tidy_gerrit.py: http://gerrit.cloudera.org:8080/#/c/14839/1/build-support/clang_tidy_gerrit.py@53 PS1, Line 53: With introduction of LLVM 9.0 as it turns out it wasn't introduced by LLVM 9, this part is incorrec -- To view, visit http://gerrit.cloudera.org:8080/14839 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1f0e3a5b8447940be74071cc6701ac5eb5ddcf6 Gerrit-Change-Number: 14839 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 05 Dec 2019 01:50:34 +0000 Gerrit-HasComments: Yes
