Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14855 )
Change subject: Improve SIMD code generation for primitive predicates ...................................................................... Patch Set 1: (2 comments) Cool! Were you able to verify from the generated asm? http://gerrit.cloudera.org:8080/#/c/14855/1/src/kudu/common/column_predicate.cc File src/kudu/common/column_predicate.cc: http://gerrit.cloudera.org:8080/#/c/14855/1/src/kudu/common/column_predicate.cc@742 PS1, Line 742: lower_ Bug: upper_ http://gerrit.cloudera.org:8080/#/c/14855/1/src/kudu/common/column_predicate.cc@750 PS1, Line 750: DataTypeTraits<PhysicalType> Nit: Why not use traits here as well and similarly below? -- To view, visit http://gerrit.cloudera.org:8080/14855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1772584c1d0c53128608ea26248dd4ab069b8108 Gerrit-Change-Number: 14855 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 05 Dec 2019 20:55:57 +0000 Gerrit-HasComments: Yes
