Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14855 )
Change subject: Improve SIMD code generation for primitive predicates ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14855/1/src/kudu/common/column_predicate.cc File src/kudu/common/column_predicate.cc: http://gerrit.cloudera.org:8080/#/c/14855/1/src/kudu/common/column_predicate.cc@742 PS1, Line 742: lower_ > Yeah, this suggests we have a gap in our test coverage. Could you fill it? I don't think there's a gap in the test coverage-- a bunch of tests failed with this patch :) http://gerrit.cloudera.org:8080/#/c/14855/1/src/kudu/common/column_predicate.cc@745 PS1, Line 745: = > It'd be even better to capture just the local variable by value instead of Done http://gerrit.cloudera.org:8080/#/c/14855/1/src/kudu/common/column_predicate.cc@750 PS1, Line 750: DataTypeTraits<PhysicalType> > Nit: Why not use traits here as well and similarly below? Done -- To view, visit http://gerrit.cloudera.org:8080/14855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1772584c1d0c53128608ea26248dd4ab069b8108 Gerrit-Change-Number: 14855 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 06 Dec 2019 00:31:52 +0000 Gerrit-HasComments: Yes
