Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14743 )
Change subject: KUDU-3001 Multi-thread to load containers in a data directory ...................................................................... Patch Set 13: Verified+1 (2 comments) LGTM, just some nits. http://gerrit.cloudera.org:8080/#/c/14743/13/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/14743/13/src/kudu/fs/data_dirs.cc@104 PS13, Line 104: fs_thread_count_per_data_dir nit: should this be named as max_fs_thread_count_per_data_dir to reflect it is the maximum? http://gerrit.cloudera.org:8080/#/c/14743/13/src/kudu/fs/log_block_manager.h File src/kudu/fs/log_block_manager.h: http://gerrit.cloudera.org:8080/#/c/14743/13/src/kudu/fs/log_block_manager.h@332 PS13, Line 332: RepairTask nit: can you add a comment for this method? -- To view, visit http://gerrit.cloudera.org:8080/14743 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0721ee4a5a6824db146ba0658e60eec25dd0c65c Gerrit-Change-Number: 14743 Gerrit-PatchSet: 13 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: wangning <[email protected]> Gerrit-Comment-Date: Fri, 06 Dec 2019 21:55:32 +0000 Gerrit-HasComments: Yes
