Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14868 )
Change subject: client: optimize destruction of WriteRpc ...................................................................... Patch Set 2: > Patch Set 2: Code-Review+2 > > > not a race, I just didn't handle the failure case where the write_op() had > > been set to null prior to WriteRpc destruction, I think. fixing > > Can you remind me how that can happen? In the MarkInFlightOpFailed() code path, we release the op from an InFlightOp -- To view, visit http://gerrit.cloudera.org:8080/14868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I538f995f7ec161e746885c6b31cd1dccd72139b0 Gerrit-Change-Number: 14868 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 09 Dec 2019 21:14:58 +0000 Gerrit-HasComments: No
