Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14879 )
Change subject: [python] KUDU-1938 Add VARCHAR support ...................................................................... Patch Set 2: (1 comment) > Patch Set 1: > > Could you add some unit tests to exercise the new code? Added some unit tests and also extended the test table with a varchar column. http://gerrit.cloudera.org:8080/#/c/14879/1/python/kudu/libkudu_client.pxd File python/kudu/libkudu_client.pxd: http://gerrit.cloudera.org:8080/#/c/14879/1/python/kudu/libkudu_client.pxd@372 PS1, Line 372: Status SetNull(Slice& col_name) > Do we need the NoCopyUnsafe methods in the python client? nope, I thought it might be a good idea to add it for parity, but on second thought it's safer if we don't expose it needlessly. -- To view, visit http://gerrit.cloudera.org:8080/14879 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27b2a85c9caa3f026f4fb0ab8974899babb01dac Gerrit-Change-Number: 14879 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 12 Dec 2019 01:24:06 +0000 Gerrit-HasComments: Yes
