Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14879 )
Change subject: [python] KUDU-1938 Add VARCHAR support ...................................................................... Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14879/6/python/kudu/tests/test_schema.py File python/kudu/tests/test_schema.py: http://gerrit.cloudera.org:8080/#/c/14879/6/python/kudu/tests/test_schema.py@191 PS6, Line 191: .length(10)) Does it make sense to add test for some nonsense length values like -1? What's expected if calling builder.length(-1) ? -- To view, visit http://gerrit.cloudera.org:8080/14879 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27b2a85c9caa3f026f4fb0ab8974899babb01dac Gerrit-Change-Number: 14879 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 13 Dec 2019 06:36:05 +0000 Gerrit-HasComments: Yes
