Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14931 )
Change subject: log: use RWFile in log segments ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14931/1/src/kudu/consensus/log.cc File src/kudu/consensus/log.cc: http://gerrit.cloudera.org:8080/#/c/14931/1/src/kudu/consensus/log.cc@549 PS1, Line 549: opts_->preallocate_segments && : active_segment_->written_offset() < max_segment_size_ > Why are these conditions important? Mind commenting? Done -- To view, visit http://gerrit.cloudera.org:8080/14931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65b39e219e76876df16e698211eb558ab31329c8 Gerrit-Change-Number: 14931 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 19 Dec 2019 09:15:04 +0000 Gerrit-HasComments: Yes
