Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14931 )
Change subject: log: use RWFile in log segments ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14931/2/src/kudu/consensus/log.cc File src/kudu/consensus/log.cc: http://gerrit.cloudera.org:8080/#/c/14931/2/src/kudu/consensus/log.cc@549 PS2, Line 549: // max_segment_size_ defines the (soft) limit of a segment. When preallocation : // is enabled, max_segment_size also defines the amount of space that is : // preallocated at segment creation time. : // > Well, it hints at how preallocation is related (i.e. to return excess preal Thanks. Yeah, I just wanted to make sure there relationship between preallocation and truncation was clearer, and why truncation doesn't make sense if we're not preallocating. -- To view, visit http://gerrit.cloudera.org:8080/14931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65b39e219e76876df16e698211eb558ab31329c8 Gerrit-Change-Number: 14931 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 19 Dec 2019 22:35:10 +0000 Gerrit-HasComments: Yes
