Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14940 )
Change subject: [clang-tidy] Remove inline comments in .clang-tidy config file ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+2 > > I assume you ran 'make tidy' with that config and it works for you as > expected, right? Yes. Without this change make tidy would trigger readability-magic-number check on my other FastHash change. With this change, readability-magic-number check is not triggered. Moreover I explicitly enabled it to verify that check is triggered. -- To view, visit http://gerrit.cloudera.org:8080/14940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2f073ff9d1e8edf7468bc4fa486fa7f16283ade Gerrit-Change-Number: 14940 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 20 Dec 2019 23:11:13 +0000 Gerrit-HasComments: No
