Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14940 )
Change subject: [clang-tidy] Remove inline comments in .clang-tidy config file ...................................................................... [clang-tidy] Remove inline comments in .clang-tidy config file Inline comments don't work inside a long string broken into multi-line strings. So move the comments above the Checks section. Verified by toggling the readability-magic-number check. Change-Id: Id2f073ff9d1e8edf7468bc4fa486fa7f16283ade Reviewed-on: http://gerrit.cloudera.org:8080/14940 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/.clang-tidy 1 file changed, 24 insertions(+), 18 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id2f073ff9d1e8edf7468bc4fa486fa7f16283ade Gerrit-Change-Number: 14940 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
