Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14947 )
Change subject: [consensus] LeaderElection cleanup ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/14947/3/src/kudu/consensus/raft_consensus.h File src/kudu/consensus/raft_consensus.h: http://gerrit.cloudera.org:8080/#/c/14947/3/src/kudu/consensus/raft_consensus.h@461 PS3, Line 461: static const char* State_Name(State state); This is a const function and should be tagged as such. http://gerrit.cloudera.org:8080/#/c/14947/3/src/kudu/consensus/raft_consensus.h@465 PS3, Line 465: static MonoDelta MinimumElectionTimeout(); const was dropped. -- To view, visit http://gerrit.cloudera.org:8080/14947 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3163ff5c7a628431a145c11133c54e26b7165cd Gerrit-Change-Number: 14947 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 26 Dec 2019 22:24:05 +0000 Gerrit-HasComments: Yes
