Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14947 )
Change subject: [consensus] LeaderElection cleanup ...................................................................... Patch Set 3: Code-Review+2 (2 comments) IIUC, the has_responder_term() changes don't affect backwards compatibility between an "old" peer and a "new" peer because for an old peer (which doesn't condition calls to responder_term() on has_responder_term()), a direct call to responder_term() will yield the default value of 0, which will always be lower than the term under election and thus will have no ill effect. Is that correct? http://gerrit.cloudera.org:8080/#/c/14947/3/src/kudu/consensus/leader_election.h File src/kudu/consensus/leader_election.h: http://gerrit.cloudera.org:8080/#/c/14947/3/src/kudu/consensus/leader_election.h@18 PS3, Line 18: #pragma once > warning: #pragma once in main file [clang-diagnostic-pragma-once-outside-he I've seen this warning show up before but haven't been able to make sense of it yet. http://gerrit.cloudera.org:8080/#/c/14947/3/src/kudu/consensus/leader_election.h@109 PS3, Line 109: const ElectionVote decision; Seems weird that this is 'decision' but the constructor argument is 'vote'. -- To view, visit http://gerrit.cloudera.org:8080/14947 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3163ff5c7a628431a145c11133c54e26b7165cd Gerrit-Change-Number: 14947 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sun, 29 Dec 2019 18:16:02 +0000 Gerrit-HasComments: Yes
