Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14958 )
Change subject: [tools] Add 'run_cleanup' option for 'kudu perf loadgen' ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14958/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14958/2//COMMIT_MSG@9 PS2, Line 9: Add 'run_cleanup' option to provide a way to cleanup test data written to : the table, especially an existing user table. > But deletions in Kudu just pile on additional load unless their rowsets are 'perf loadgen' data is written on existing columns, not associate with the issue. Sometimes, we might run 'perf loadgen' on existing table, also existing partitions, and these partitions have some data before, so we should only cleanup our own data written by 'perf loadgen'. http://gerrit.cloudera.org:8080/#/c/14958/2/src/kudu/tools/tool_action_perf.cc File src/kudu/tools/tool_action_perf.cc: http://gerrit.cloudera.org:8080/#/c/14958/2/src/kudu/tools/tool_action_perf.cc@307 PS2, Line 307: DEFINE_bool(run_cleanup, true, > Why should this default to true? This means cleanup new generated dirty data by default. -- To view, visit http://gerrit.cloudera.org:8080/14958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e75adde434bac5e88151361655526b91f327b4c Gerrit-Change-Number: 14958 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 01 Jan 2020 02:34:12 +0000 Gerrit-HasComments: Yes
