Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14958 )
Change subject: [tools] Add 'run_cleanup' option for 'kudu perf loadgen' ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14958/2/src/kudu/tools/tool_action_perf.cc File src/kudu/tools/tool_action_perf.cc: http://gerrit.cloudera.org:8080/#/c/14958/2/src/kudu/tools/tool_action_perf.cc@307 PS2, Line 307: DEFINE_bool(run_cleanup, true, > Yeah, but why does it deserve to default to on? That could surprise users w +1 to Adar's comment: I also think this should be `false` by default at least to have the new version of the tool behave the same if running with the same flags and conform the POLA principle (https://en.wikipedia.org/wiki/Principle_of_least_astonishment) In addition, since it's not possible to guarantee that the tool deletes _only_ the generated data (imagine some concurrent updates from another session), all data removal from other than the auto-created tables should be _explicit_ because it can lead to unexpected data loss. -- To view, visit http://gerrit.cloudera.org:8080/14958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e75adde434bac5e88151361655526b91f327b4c Gerrit-Change-Number: 14958 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 07 Jan 2020 19:58:29 +0000 Gerrit-HasComments: Yes
