Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14625 )
Change subject: [wip] KUDU-2971 p3: concurrent requests support for subprocess ...................................................................... Patch Set 2: (6 comments) Just skimmed over. http://gerrit.cloudera.org:8080/#/c/14625/2/src/kudu/subprocess/server.cc File src/kudu/subprocess/server.cc: http://gerrit.cloudera.org:8080/#/c/14625/2/src/kudu/subprocess/server.cc@76 PS2, Line 76: CHECK Could it be converted into DCHECK()? http://gerrit.cloudera.org:8080/#/c/14625/2/src/kudu/subprocess/server.cc@93 PS2, Line 93: threads_.push_back(new_thread); Is this a duplicate entry for the thread? What about the entry already added above at line 85? http://gerrit.cloudera.org:8080/#/c/14625/2/src/kudu/subprocess/server.cc@98 PS2, Line 98: subprocess server? http://gerrit.cloudera.org:8080/#/c/14625/2/src/kudu/subprocess/server.cc@206 PS2, Line 206: If the response has no ID, skip it Should it be at some handling for such condition at least in case of a DEBUG build for easier troubleshooting? http://gerrit.cloudera.org:8080/#/c/14625/2/src/kudu/subprocess/server.cc@217 PS2, Line 217: if (cb) { : (*cb)(s, std::move(response)); : } what if there is no callback for the id? Should it be handled somehow, at least logged? http://gerrit.cloudera.org:8080/#/c/14625/2/src/kudu/subprocess/subprocess_client-test.cc File src/kudu/subprocess/subprocess_client-test.cc: http://gerrit.cloudera.org:8080/#/c/14625/2/src/kudu/subprocess/subprocess_client-test.cc@62 PS2, Line 62: TEST_F(SubprocessClientTest, TestBasicCommmunication) { Please add a test verifying the error path (i.e. when an error is set in the response). -- To view, visit http://gerrit.cloudera.org:8080/14625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fddbc389d8c3582bda301b9390700068e3806b2 Gerrit-Change-Number: 14625 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 07 Jan 2020 20:20:51 +0000 Gerrit-HasComments: Yes
