Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14981 )
Change subject: [java] retry to connect to the cluster when specifing a superset of masters ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/14981/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14981/1//COMMIT_MSG@9 PS1, Line 9: When the user specifies more masters in the connection string than the actual : existing masters, but couldn't find a leader master, the client should retry : to connect to the cluster instead of returning with NonRecoverableException. : This will be useful when we need to add or remove masters. : > I'm not really seeing how this patch achieves this. Maybe I didn't make it clear. This patch want to achieve when the client is configured with more masters than actually exist but can't find a leader master, the client could retry to connect to the leader master. That could help when removing masters obviously, and we could also configure the client with more masters before adding masters to the cluster. http://gerrit.cloudera.org:8080/#/c/14981/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java: http://gerrit.cloudera.org:8080/#/c/14981/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java@283 PS1, Line 283: cb.call((ConnectToMasterResponsePB) response); > I think you can include this case into the existing testAggregateResponses Done http://gerrit.cloudera.org:8080/#/c/14981/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java@298 PS1, Line 298: > This (or makeCTMR, or both) need better names to differentiate between thei Done -- To view, visit http://gerrit.cloudera.org:8080/14981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66033c3ff6d217ce6b8286c94a7333b90cd26d19 Gerrit-Change-Number: 14981 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 08 Jan 2020 12:04:04 +0000 Gerrit-HasComments: Yes
