Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14981 )
Change subject: [client] retry to connect to the cluster when specifing a superset of masters ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14981/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14981/2//COMMIT_MSG@13 PS2, Line 13: > Snuck in by mistake? Done http://gerrit.cloudera.org:8080/#/c/14981/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java: http://gerrit.cloudera.org:8080/#/c/14981/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java@225 PS2, Line 225: // If the master hasn't become a leader, retry. : runTest( : reusableNRE, : reusableNRE, : makeCTMR(FOLLOWER, ImmutableList.of(MASTERS.get(0))), : retryResponse); : : // Failure case. : : // Can't recover anything, give up. : runTest( : reusableNRE, : reusableNRE, : reusableNRE, : reusableNRE); : } > Nit: could you move these so they're part of the existing "success", "retry Done -- To view, visit http://gerrit.cloudera.org:8080/14981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66033c3ff6d217ce6b8286c94a7333b90cd26d19 Gerrit-Change-Number: 14981 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 09 Jan 2020 12:28:36 +0000 Gerrit-HasComments: Yes
