Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14987 )
Change subject: env: add common File base class ...................................................................... env: add common File base class It does very little. The key is the common destructor, which simplifies the (eventual) file cache that can manage multiple file abstractions: when evicting from the underlying LRU cache, we can cast the evicted pointer to a File and trust that the appropriate destructor will be invoked. Change-Id: Ia929234ac8e935a5f1730a3ac575bfb4d1715861 Reviewed-on: http://gerrit.cloudera.org:8080/14987 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Adar Dembo <[email protected]> --- M src/kudu/util/env.cc M src/kudu/util/env.h M src/kudu/util/env_posix.cc 3 files changed, 24 insertions(+), 48 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Adar Dembo: Verified -- To view, visit http://gerrit.cloudera.org:8080/14987 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia929234ac8e935a5f1730a3ac575bfb4d1715861 Gerrit-Change-Number: 14987 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]>
