Hello Alexey Serbin, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14988
to review the following change.
Change subject: file cache: unify across file types
......................................................................
file cache: unify across file types
Back when the file cache was first added (commit 6a124f040), there was a
choice between using a templatized approach, instantiated per-file-type and
a non-templatized approach, usable by any file type. At the time, file cache
usage was restricted to the block managers, and so the templatized approach
carried the day.
Since then we've seen more and more reports of users hitting fd limits due
to high numbers of log segments. I'd like to address these by expanding the
purview of the file cache to include all long-lived opened fds, including
segment files and index chunks.
This patch lays the groundwork for that by de-templatizing the file cache,
"unifying" the it for all supported file types. Eventually, it'll be
instantiated once per server and rolled out to the WAL, but for now only the
underlying implementation changes.
Change-Id: I1e5cf6cadb7f0d45492af8b8a7541853d587409c
---
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/file_block_manager.h
M src/kudu/fs/log_block_manager.cc
M src/kudu/fs/log_block_manager.h
M src/kudu/util/file_cache-stress-test.cc
M src/kudu/util/file_cache-test.cc
M src/kudu/util/file_cache.cc
M src/kudu/util/file_cache.h
8 files changed, 376 insertions(+), 210 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/14988/1
--
To view, visit http://gerrit.cloudera.org:8080/14988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e5cf6cadb7f0d45492af8b8a7541853d587409c
Gerrit-Change-Number: 14988
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
