Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14866 )
Change subject: WIP [util] utilities to get info on cloud instance ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14866/1/src/kudu/util/cloud/instance_metadata.cc File src/kudu/util/cloud/instance_metadata.cc: http://gerrit.cloudera.org:8080/#/c/14866/1/src/kudu/util/cloud/instance_metadata.cc@86 PS1, Line 86: "169.254.169.123" > This kind of information should be stored in some configuration file. I'm not sure I follow. Configuration file for what? This is a pre-defined IP address for NTP server at any AWS instance. http://gerrit.cloudera.org:8080/#/c/14866/1/src/kudu/util/cloud/instance_metadata.cc@104 PS1, Line 104: "http://169.254.169.254"; : "/latest/meta-data/instance-id" > This kind of information should be stored in some configuration file. ditto http://gerrit.cloudera.org:8080/#/c/14866/1/src/kudu/util/cloud/instance_metadata.cc@121 PS1, Line 121: "http://169.254.169.254"; : "/metadata/instance/compute/vmId?api-version=2018-10-01&format=text" > This kind of information should be stored in some configuration file. Ditto -- configuration file for what? -- To view, visit http://gerrit.cloudera.org:8080/14866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I083f4803decaef5d6e7d44184bbd98b074d2578b Gerrit-Change-Number: 14866 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Thu, 09 Jan 2020 06:02:53 +0000 Gerrit-HasComments: Yes
