Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14866 )
Change subject: WIP [util] utilities to get info on cloud instance ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14866/1/src/kudu/util/cloud/instance_metadata.cc File src/kudu/util/cloud/instance_metadata.cc: http://gerrit.cloudera.org:8080/#/c/14866/1/src/kudu/util/cloud/instance_metadata.cc@86 PS1, Line 86: "169.254.169.123" > Sorry, I never saw IP address hardcoded. IMHO, it should be placed in textu We could place some configuration properties into a configuration file, but kudu-tserver and kudu-master don't have a configuration files as of now except, maybe, flagsfile. Probably, it would make sense to make this IP address and other properties configurable via run-time flags, but I don't think these are going to change ever till cloud providers support dedicated NTP servers. If the API used here is changed so it requires something to change in these would-be-configuration-properties, I expect _all_ this code should be rewritten. At least that's the impression I got while reading public documentation on the these topics. -- To view, visit http://gerrit.cloudera.org:8080/14866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I083f4803decaef5d6e7d44184bbd98b074d2578b Gerrit-Change-Number: 14866 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2020 21:20:56 +0000 Gerrit-HasComments: Yes
