Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14993 )
Change subject: [docker] Adjust entrypoint variable to be more composable ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14993/1/docker/kudu-entrypoint.sh File docker/kudu-entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/14993/1/docker/kudu-entrypoint.sh@61 PS1, Line 61: MASTER_ARGS=${MASTER_ARGS:=""} : TSERVER_ARGS=${TSERVER_ARGS:=""} This longer format is unnecessary; I think you could just do: MASTER_ARGS= TSERVER_ARGS= -- To view, visit http://gerrit.cloudera.org:8080/14993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3451b3bb2d398f8e0bdea881103b6d4a74cb753 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 09 Jan 2020 17:22:27 +0000 Gerrit-HasComments: Yes
